From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 07 Feb 2007 17:35:30 GMT
Subject: Re: [RFC/PATCH] fast-import: Fix compile warnings
Message-ID: <Pine.LNX.4.63.0702071829450.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vzm7p7uf9.fsf@assigned-by-dhcp.cox.net>

Hi,

On Wed, 7 Feb 2007, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Not on all platforms are size_t and unsigned long equivalent.
> > Since I do not know how portable %z is, I play safe, and just
> > cast the respective variables to unsigned long.
> 
> The format "%s %lu" is consistent with what write_sha1_file_prepare()
> and unpack_sha1_header() uses, so that should be safe enough.

So, should we cast to (unsigned long) to make the gcc warning go away, or 
do we not care at all?

> However, your patch does not apply.

Hmm. Strange, I thought that I only changed the in_merge_bases() line... 
Will have a look tomorrow.

Ciao,
Dscho