Re: [PATCH] git-format-patch -3

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 18, 2007, 01:25 UTC
Message-ID: <Pine.LNX.4.63.0701180221010.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vk5zlqqum.fsf@assigned-by-dhcp.cox.net>

Hi,

On Wed, 17 Jan 2007, Junio C Hamano wrote:

>  * I think this is incompatible with --ignore-if-upstream, which
>    I haven't bothered to look into yet.

Uhm. What exactly _would_ be upstream?

At the moment, for "--ignore-if-in-upstream" we handle _only_ ranges (a..b), where we treat the left part as the upstream, so we first parse all the diffs in b..a, and then ignore all commits in a..b which have an already-seen diff hash.

However, if we want to do the logical analogue with "-22 HEAD", the equivalent to b..a would trivially contain no commits at all.

>    Likes, dislikes?

It sure is supported by the principle of least surprise.

Ciao, Dscho