Re: [PATCH] Replacing the system call pread() with lseek()/xread()/lseek() sequence.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 10, 2007, 00:30 UTC
- Message-ID
- <Pine.LNX.4.63.0701100128410.22628@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <7v7ivvivej.fsf@assigned-by-dhcp.cox.net>
Hi,
On Tue, 9 Jan 2007, Junio C Hamano wrote:
> The caller of pread() does not care the current position, but that is > not to mean it does not care the position after pread() returns. The > current callers do not care, though.
Not completely true. We fixed in v1.4.4.1~23 a bug which was triggered by NO_MMAP. Since this recently became the default for cygwin, "git-index-pack --fix-thin" would fail in most cases.
Ciao, Dscho