Re: [PATCH] Speedup recursive by flushing index only once for all entries

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 4, 2007, 12:33 UTC
Message-ID: <Pine.LNX.4.63.0701041327490.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <81b0412b0701040247k47e398e6q34dd5233bb5706f6@mail.gmail.com>

Hi,

On Thu, 4 Jan 2007, Alex Riesen wrote:

> Johannes, I remember suggesting to do index flush for all
> entries instead for every entry. It is already quite time ago,
> but ... was there any reasons for not doing this?

I wanted to be on the safe side, and eventually look through the code again for possible problems.

I think what you did is safe, since you moved the call from process_entry() to its sole caller, merge_trees().

However, I was wondering if the index has to be written at all. I expect the written index (except the last one, of course) to have no user...

Ciao, Dscho