Re: [PATCH] Speedup recursive by flushing index only once for all entries

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jan 4, 2007, 12:47 UTC
Message-ID: <81b0412b0701040447u329dcf9bvcd7adb9e9d199f18@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.63.0701041327490.22628@wbgn013.biozentrum.uni-wuerzburg.de>

On 1/4/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 10 quoted lines

>
> > Johannes, I remember suggesting to do index flush for all
> > entries instead for every entry. It is already quite time ago,
> > but ... was there any reasons for not doing this?
>
> I wanted to be on the safe side, and eventually look through the code
> again for possible problems.
>
> I think what you did is safe, since you moved the call from
> process_entry() to its sole caller, merge_trees().

Me too, just wondered why didn't we do this back then. Anyway, my "monster-merge" and the builtin tests pass with no visible problems.

> However, I was wondering if the index has to be written at all.
> I expect the written index (except the last one, of course) to have no
> user...

Good question...