git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/7] Switch git_mmap to use pread.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 24, 2006, 13:09 UTC
Message-ID
<Pine.LNX.4.63.0612241407250.19693@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<20061224054547.GB8146@spearce.org>
Hi,
On Sun, 24 Dec 2006, Shawn O. Pearce wrote:
Show 5 quoted lines
> Now that Git depends on pread in index-pack its safe to say we can
> also depend on it within the git_mmap emulation we activate when
> NO_MMAP is set.  On most systems pread should be slightly faster
> than an lseek/read/lseek sequence as its one system call vs. three
> system calls.

I don't think it matters much. The _only_ platform we really use NO_MMAP (other than for testing) is Windows, and AFAICT it does not have pread(), so it is emulated by lseek/read/lseek anyway.

But it's a cleanup, and it deletes more lines than it adds, so Ack from me.

Ciao, Dscho

Previous: Shawn O. PearceNext: Alon Ziv
Message 2 of 13 in “Switch git_mmap to use pread.”
  1. 2/7 Switch git_mmap to use pread.Shawn O. Pearce, Dec 24, 2006
  2. Johannes SchindelinDec 24, 2006
  3. Alon ZivDec 24, 2006
  4. Shawn PearceDec 24, 2006
  5. Linus TorvaldsDec 24, 2006
  6. 3/7 Ensure packed_git.next is initialized to NULL.Shawn O. Pearce, Dec 24, 2006
  7. 4/7 Default core.packdGitWindowSize to 1 MiB if NO_MMAP.Shawn O. Pearce, Dec 24, 2006
  8. 5/7 Don't exit successfully on EPIPE in read_or_die.Shawn O. Pearce, Dec 24, 2006
  9. 6/7 Release pack windows before reporting out of memory.Shawn O. Pearce, Dec 24, 2006
  10. Johannes SchindelinDec 24, 2006
  11. 7/7 Replace mmap with xmmap, better handling MAP_FAILED.Shawn O. Pearce, Dec 24, 2006
  12. Johannes SchindelinDec 24, 2006
  13. Shawn PearceDec 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.