From: Johannes Schindelin Date: Sun, 24 Dec 2006 13:09:23 GMT Subject: Re: [PATCH 2/7] Switch git_mmap to use pread. Message-ID: In-Reply-To: <20061224054547.GB8146@spearce.org> Hi, On Sun, 24 Dec 2006, Shawn O. Pearce wrote: > Now that Git depends on pread in index-pack its safe to say we can > also depend on it within the git_mmap emulation we activate when > NO_MMAP is set. On most systems pread should be slightly faster > than an lseek/read/lseek sequence as its one system call vs. three > system calls. I don't think it matters much. The _only_ platform we really use NO_MMAP (other than for testing) is Windows, and AFAICT it does not have pread(), so it is emulated by lseek/read/lseek anyway. But it's a cleanup, and it deletes more lines than it adds, so Ack from me. Ciao, Dscho