Re: [PATCH] perl bindings fix compilation errors

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 25, 2006, 11:38 UTC
Message-ID: <Pine.LNX.4.63.0609251336380.25371@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <4517BEBC.4000002@shadowen.org>

Hi,

On Mon, 25 Sep 2006, Andy Whitcroft wrote:

Show 18 quoted lines

> Johannes Schindelin wrote:
> > Hi,
> > 
> > On Mon, 25 Sep 2006, Andy Whitcroft wrote:
> > 
> >> With the introduction of Makefile.PL to the perl bindings we no
> >> longer seem to pass in either the definition of SHA1_HEADER or
> >> GIT_VERSION.  It seems we no longer pass over the BASIC_FLAGS into
> >> the compilation.
> > 
> > You probably got bitten by the fact that earlier runs left Git.c in the 
> > perl/ directory. Go to perl/, "make distclean", and make git again.
> 
> Hmmm that sucks.  Yes, I had to make distclean more than once, but it
> seems to fix things.
> 
> I am somewhat unhappy that a make clean at the top level and remake was
> not sufficient to get a working tree.

Yes. I almost submitted a patch which checks for perl/Git.c, and makes distclean in perl/ if exists.

Ciao, Dscho