git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] perl bindings fix compilation errors

From
Andy Whitcroft <apw@shadowen.org>
Date
Sep 25, 2006, 10:03 UTC
Message-ID
<20060925100319.GA1655@shadowen.org>
perl bindings: fix compilation errors

With the introduction of Makefile.PL to the perl bindings we no longer seem to pass in either the definition of SHA1_HEADER or GIT_VERSION. It seems we no longer pass over the BASIC_FLAGS into the compilation.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
diff --git a/Makefile b/Makefile
index d705e06..d32f4c4 100644
--- a/Makefile
+++ b/Makefile
@@ -603,7 +603,7 @@ all: $(ALL_PROGRAMS) $(BUILT_INS) git$X 
 	git-merge-recur$X
 
 all: perl/Makefile
-	$(MAKE) -C perl
+	$(MAKE) -C perl GIT_VERSION='$(GIT_VERSION)' BASIC_CFLAGS="$(BASIC_CFLAGS)"
 	$(MAKE) -C templates
 
 strip: $(PROGRAMS) git$X
diff --git a/perl/Makefile.PL b/perl/Makefile.PL
index de73235..00fc779 100644
--- a/perl/Makefile.PL
+++ b/perl/Makefile.PL
@@ -5,6 +5,8 @@ sub MY::postamble {
 instlibdir:
 	@echo '$(INSTALLSITELIB)'
 
+CCFLAGS += -DGIT_VERSION='"$(GIT_VERSION)"' $(BASIC_CFLAGS)
+
 MAKE_FRAG
 }
 
Next: Johannes Schindelin
Message 1 of 8 in “perl bindings fix compilation errors”
  1. perl bindings fix compilation errorsAndy Whitcroft, Sep 25, 2006
  2. Johannes SchindelinSep 25, 2006
  3. Andy WhitcroftSep 25, 2006
  4. Johannes SchindelinSep 25, 2006
  5. Junio C HamanoSep 26, 2006
  6. Johannes SchindelinSep 26, 2006
  7. Junio C HamanoSep 27, 2006
  8. Johannes SchindelinSep 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.