git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix crash when GIT_DIR is invalid

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 4, 2006, 22:42 UTC
Message-ID
<Pine.LNX.4.63.0608050041230.1800@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7virl8jpnw.fsf@assigned-by-dhcp.cox.net>
Hi,
On Fri, 4 Aug 2006, Junio C Hamano wrote:
Show 8 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >  	bad_dir_environ:
> > -		if (!nongit_ok) {
> > +		if (nongit_ok) {
> >  			*nongit_ok = 1;
> 
> *BLUSH*  How could I have missed something like this...

It's too easy. I actually reviewed that patch, saw that I did the same (not!), and hit the bug...

Ciao, Dscho "errare humanum est" --

Previous: Junio C Hamano
Message 3 of 3 in “Fix crash when GIT_DIR is invalid”
  1. Fix crash when GIT_DIR is invalidJohannes Schindelin, Aug 4, 2006
  2. Junio C HamanoAug 4, 2006
  3. Johannes SchindelinAug 4, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.