From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 04 Aug 2006 22:42:27 GMT
Subject: Re: [PATCH] Fix crash when GIT_DIR is invalid
Message-ID: <Pine.LNX.4.63.0608050041230.1800@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7virl8jpnw.fsf@assigned-by-dhcp.cox.net>

Hi,

On Fri, 4 Aug 2006, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >  	bad_dir_environ:
> > -		if (!nongit_ok) {
> > +		if (nongit_ok) {
> >  			*nongit_ok = 1;
> 
> *BLUSH*  How could I have missed something like this...

It's too easy. I actually reviewed that patch, saw that I did the same 
(not!), and hit the bug...

Ciao,
Dscho "errare humanum est" --