Re: [PATCH 3/5] git-instaweb: store parameters in config
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 26, 2006, 21:13 UTC
- Message-ID
- <Pine.LNX.4.63.0607262311560.29667@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <Pine.LNX.4.63.0607262147280.29667@wbgn013.biozentrum.uni-wuerzburg.de>
Hi,
On Wed, 26 Jul 2006, Johannes Schindelin wrote:
Show 12 quoted lines
> On Wed, 26 Jul 2006, Junio C Hamano wrote: > > > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > > > It already reads the config for defaults, and now it also stores > > > the last passed parameters in the config. > > > > This might need to be conditional -- usually people override the > > default from the command line as a one-shot thing, and storing > > them in the configuration file would upset them. > > I agree that this should be conditional, but the other way round, no?
Being bitten by my own words. It is plain dumb to store parameters for which instaweb fails. And my patch did that. Oh, well.
So, I'd say: just forget about patches [3-5]/5.
Ciao, Dscho