Re: [PATCH 3/5] git-instaweb: store parameters in config

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 26, 2006, 19:53 UTC
Message-ID: <Pine.LNX.4.63.0607262147280.29667@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7v3bcorxbd.fsf@assigned-by-dhcp.cox.net>

Hi,

On Wed, 26 Jul 2006, Junio C Hamano wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > It already reads the config for defaults, and now it also stores
> > the last passed parameters in the config.
> 
> This might need to be conditional -- usually people override the
> default from the command line as a one-shot thing, and storing
> them in the configuration file would upset them.

I agree that this should be conditional, but the other way round, no? git-instaweb is meant as a one-shot install thing, so I would like to do this in some arbitrary repo:

	git-instaweb

and see a browser. Okay, so it does not work: I do not have LigHTTP, and my apache is not in the path (and you need to specify the modules-path anyway, if it is different than /usr/lib/apache2/modules), so I do

	git-instaweb --httpd=/usr/local/apache2/bin/httpd\ -f \
		--module-path=/usr/local/apache2/modules

Works! After I played a little with it (or rebooted the computer), I would like to start it again:

	git-instaweb

My point being: you do not really need a different configuration with git-instaweb, once you got it right.

Ciao, Dscho