Re: [PATCH] Make git-fmt-merge-msg a builtin

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 3, 2006, 15:45 UTC
Message-ID: <Pine.LNX.4.63.0607031731550.29667@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20060703182621.dbed5b5f.tihirvon@gmail.com>

Hi,

On Mon, 3 Jul 2006, Timo Hirvonen wrote:

Show 9 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> 
> > I had in mind that I want to use path-list instead (which is cooking in 
> > the merge-recursive efforts ATM). And there, I would add a flag 
> > needs_payload. Opinions?
> 
> This code is so simple that making the path_list more complex 
> (needs_payload special case?) is not worth it.  I have not looked at the 
> code very closely though and have no idea what I'm talking about :)

Okay. But I'd rather go back to work on merge-recursive, and just reuse the path_list struct.

Show 6 quoted lines

> > > free(NULL) is safe.
> > 
> > Is it? I vaguely remember that I had problems with this on some obscure 
> > platform.
> 
> I don't think so.

Well, after a little Googling, I am more convinced than ever that it is a BAD thing to rely on free(NULL) being a NOP.

Ciao, Dscho