git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Make git-fmt-merge-msg a builtin

From
THTimo Hirvonen <tihirvon@gmail.com>
Date
Jul 3, 2006, 16:16 UTC
Message-ID
<20060703191635.21ba0af3.tihirvon@gmail.com>
In-Reply-To
<Pine.LNX.4.63.0607031731550.29667@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 9 quoted lines
> > > > free(NULL) is safe.
> > > 
> > > Is it? I vaguely remember that I had problems with this on some obscure 
> > > platform.
> > 
> > I don't think so.
> 
> Well, after a little Googling, I am more convinced than ever that it is a 
> BAD thing to rely on free(NULL) being a NOP.

I did some research too. Seems that C89 requires free(NULL) to be a no-op but on some old systems (SunOS) it may crash. IMNSHO these systems were designed to crash valid programs and torture developers. There are probably many free(NULL) and realloc(NULL, ...) uses in the git source code and are not worth fixing.

-- 
http://onion.dynserv.net/~timo/
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 6 of 7 in “Make git-fmt-merge-msg a builtin”
  1. Make git-fmt-merge-msg a builtinJohannes Schindelin, Jul 3, 2006
  2. Timo HirvonenJul 3, 2006
  3. Johannes SchindelinJul 3, 2006
  4. Timo HirvonenJul 3, 2006
  5. Johannes SchindelinJul 3, 2006
  6. Timo HirvonenJul 3, 2006
  7. Johannes SchindelinJul 3, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.