git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Release config lock if the regex is invalid

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 8, 2006, 11:28 UTC
Message-ID
<Pine.LNX.4.63.0605081327350.28989@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7v7j4xi6lo.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sun, 7 May 2006, Junio C Hamano wrote:
Show 9 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > This is not enough. There are quite a few exit paths. Notice the "goto 
> > out_free"? That is where this must go.
> >
> > This patch is totally untested but obviously correct:
> 
> except that many places you already close(fd) and
> unlink(lock_file).

Yes, my bad. I forgot to look for (and remove) them. Your patch looks fine to me.

Ciao, Dscho

Previous: Junio C Hamano
Message 5 of 5 in “Release config lock if the regex is invalid”
  1. Release config lock if the regex is invalidPavel Roskin, May 7, 2006
  2. Junio C HamanoMay 7, 2006
  3. Johannes SchindelinMay 8, 2006
  4. Junio C HamanoMay 8, 2006
  5. Johannes SchindelinMay 8, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.