From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 08 May 2006 11:28:31 GMT
Subject: Re: [PATCH] Release config lock if the regex is invalid
Message-ID: <Pine.LNX.4.63.0605081327350.28989@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7v7j4xi6lo.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sun, 7 May 2006, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > This is not enough. There are quite a few exit paths. Notice the "goto 
> > out_free"? That is where this must go.
> >
> > This patch is totally untested but obviously correct:
> 
> except that many places you already close(fd) and
> unlink(lock_file).

Yes, my bad. I forgot to look for (and remove) them. Your patch looks fine 
to me.

Ciao,
Dscho