Re: [PATCH] repo-config: support --get-regexp and fix crash

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 3, 2006, 11:55 UTC
Message-ID: <Pine.LNX.4.63.0605031353300.4017@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vmze0j97u.fsf@assigned-by-dhcp.cox.net>

Hi,

On Tue, 2 May 2006, Junio C Hamano wrote:

Show 6 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > 	Junio made me aware of a crash, a fix for which was too easy to
> > 	merit a separate patch.
> 
> Not really.

Right. I was just too lazy.

Show 8 quoted lines

> > 	Strange thing I realized: A value is white-space-trimmed at the end
> > 	only if the line does not end with a comment. This fact is accounted
> > 	for in the new tests.
> 
> Thanks - a note like this helps me quite a bit, because I
> usually apply e-mailed patches with --whitespace=strip, which
> would have destroyed the test, leaving me scratching my head
> without such a notice.

Apparently, I hid that note well: somebody complained privately that my patch is not white-space clean.

As for the --get-regexp part: just take your time. It was easy enough, and I think it is quite cool, but I have to see an application for it yet.

Ciao, Dscho