Re: [PATCH] repo-config: support --get-regexp and fix crash

From: Junio C Hamano <junkio@cox.net>
Date: May 2, 2006, 23:30 UTC
Message-ID: <7vmze0j97u.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0605021422150.7051@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> 	Junio made me aware of a crash, a fix for which was too easy to
> 	merit a separate patch.

Not really. The fix is clean-and-obvious, and is readily applicable to "master" without being cooked in "next". On the other hand, --get-regexp may or may not be so; by conflating the two, you are delaying the trivial and useful fix unnecessarily.

I already split the patch and applied the fix on "master", while keeping the rest in "pu" (sorry, I ran out of patience to test everything to put it in "next" -- will do so tomorrow).

It is usually a good idea to avoid making an otherwise good clean patch a hostage to new features (intentionally or accidentally).

> 	Strange thing I realized: A value is white-space-trimmed at the end
> 	only if the line does not end with a comment. This fact is accounted
> 	for in the new tests.

Thanks - a note like this helps me quite a bit, because I usually apply e-mailed patches with --whitespace=strip, which would have destroyed the test, leaving me scratching my head without such a notice.