Re: [RFC] t5300 considered dangerous
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 27, 2005, 14:08 UTC
- Message-ID
- <Pine.LNX.4.63.0512271507490.318@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <Pine.LNX.4.63.0512271452470.17086@wbgn013.biozentrum.uni-wuerzburg.de>
Hi,
On Tue, 27 Dec 2005, Johannes Schindelin wrote:
Show 15 quoted lines
> On Mon, 26 Dec 2005, Junio C Hamano wrote:
>
> > cp test-1-${packname_1}.pack test-3.pack &&
> > - dd if=/dev/zero of=test-3.idx count=1 bs=1 conv=notrunc seek=1200 &&
> > + dd if=/dev/zero of=test-3.idx count=20 bs=1 conv=notrunc seek=$l &&
> > if git-verify-pack test-3.pack
> > then false
> > else :;
>
> When the commit is not skipped, I fail to see why this should not fail in
> one out of 256 cases: the input is (partially) pseudo-random. The last 20
> bytes are the SHA-1 which should inherit this pseudo-randomness. So, the
> first byte should be pseudo-random, too.
>
> Something I missed?Yes, I missed the "count=20".
Sorry, Dscho