git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Initial AIX portability fixes.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 6, 2005, 23:58 UTC
Message-ID
<Pine.LNX.4.63.0512070055430.5888@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<20493.1133907616@lotus.CS.Berkeley.EDU>
Hi,
On Tue, 6 Dec 2005, Jason Riedy wrote:
> -#define _XOPEN_SOURCE /* glibc2 needs this */
> +#define _XOPEN_SOURCE 500 /* glibc2 and AIX 5.3L need this */
> +#define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */

Why not enclose the #define in #ifndef/#endif, and do the real magic in the Makefile? Within the AIX clause:

	ALL_CFLAGS += -D_XOPEN_SOURCE=500 -XOPEN_SOURCE_EXTENDED=1

This way the source does not get cluttered with platform dependent defines.

Hth, Dscho

Previous: Jason RiedyNext: Jason Riedy
Message 2 of 5 in “Initial AIX portability fixes.”
  1. Initial AIX portability fixes.Jason Riedy, Dec 6, 2005
  2. Johannes SchindelinDec 6, 2005
  3. Jason RiedyDec 7, 2005
  4. Junio C HamanoDec 7, 2005
  5. Junio C HamanoDec 7, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.