Re: [PATCH] Initial AIX portability fixes.

From: Junio C Hamano <junkio@cox.net>
Date: Dec 7, 2005, 00:12 UTC
Message-ID: <7vvey1zrwb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <21075.1133914036@lotus.CS.Berkeley.EDU>

Jason Riedy <ejr@EECS.Berkeley.EDU> writes:

Show 9 quoted lines

> And Johannes Schindelin writes:
>  - Why not enclose the #define in #ifndef/#endif, and do the real magic in 
>  - the Makefile? Within the AIX clause:
>  - 	ALL_CFLAGS += -D_XOPEN_SOURCE=500 -XOPEN_SOURCE_EXTENDED=1
>
> Because other files do _not_ compile when given those options.
> I'm going for minimal changes to the existing structure; the
> #define for glibc2 has been there a long, long time.  Yes, it
> probably can be done better, but these are 1.0rc versions...

I agree with your approach of least impact for now.  Thanks.