Re: [PATCH 0/4] Recovery after interrupted HTTP(s) fetch
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Sep 14, 2005, 20:55 UTC
- Message-ID
- <Pine.LNX.4.63.0509141641290.23242@iabervon.org>
- In-Reply-To
- <Pine.LNX.4.58.0509141325310.26803@g5.osdl.org>
On Wed, 14 Sep 2005, Linus Torvalds wrote:
Show 9 quoted lines
> On Wed, 14 Sep 2005, Junio C Hamano wrote: > > > > Thanks for the patch. > > This is wrong. > > Any "fetch" logic that writes the refs before all the objects are gathered > is _buggy_. It's not about "recovery", it should never do that in the > first place.
It's not about the refs at all. The issue is that, when it reaches a commit that we already have, it assumes that we have everything that commit references and stops there. It really ought to not do that, but I think it might be too slow if it goes through everything all the time. We probably want to keep a cache listing some commits we have, and use that.
-Daniel *This .sig left intentionally blank*