git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Recovery after interrupted HTTP(s) fetch

From
Junio C Hamano <junkio@cox.net>
Date
Sep 14, 2005, 20:48 UTC
Message-ID
<7vacifgyv2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.58.0509141325310.26803@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
> Any "fetch" logic that writes the refs before all the objects are gathered 
> is _buggy_. It's not about "recovery", it should never do that in the 
> first place.

I agree about refs, but in this case what is stored, and is used as a signal not to refetch to the next run, is the commit object. Ideally we should defer creating trees until we store all blobs and subtrees, and commits until we do its tree, but the fetch.c (formerly called pull.c) is not written that way from day one.

> Is it just the http one that is this broken?
I belive all of the commit walkers share this property.
Previous: Linus TorvaldsNext: Daniel Barkalow
Message 8 of 15 in “Recovery after interrupted HTTP(s) fetch”
  1. 0/4 Recovery after interrupted HTTP(s) fetchSergey Vlasov, Sep 14, 2005
  2. 1/4 Do not try to process objects more than once during fetchSergey Vlasov, Sep 14, 2005
  3. 2/4 git-*-fetch: Gracefully recover from retrieval failureSergey Vlasov, Sep 14, 2005
  4. 3/4 git-fetch: Add --recover optionSergey Vlasov, Sep 14, 2005
  5. 4/4 Document git-fetch optionsSergey Vlasov, Sep 14, 2005
  6. Junio C HamanoSep 14, 2005
  7. Linus TorvaldsSep 14, 2005
  8. Junio C HamanoSep 14, 2005
  9. Daniel BarkalowSep 14, 2005
  10. Linus TorvaldsSep 14, 2005
  11. Daniel BarkalowSep 14, 2005
  12. Junio C HamanoSep 14, 2005
  13. Matthias UrlichsSep 15, 2005
  14. Daniel BarkalowSep 15, 2005
  15. Junio C HamanoSep 15, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.