Re: git full diff output issues..

From: Anton Altaparmakov <aia21@cam.ac.uk>
Date: May 26, 2005, 19:53 UTC
Message-ID: <Pine.LNX.4.60.0505262036500.16829@hermes-1.csi.cam.ac.uk>
In-Reply-To: <Pine.LNX.4.58.0505261223240.2307@ppc970.osdl.org>

On Thu, 26 May 2005, Linus Torvalds wrote:

Show 21 quoted lines

> On Thu, 26 May 2005, Linus Torvalds wrote:
> > 
> > So we'd change it from
> > 
> > 	deleted file mode 100644
> > 
> > to
> > 
> > 	deleted file mode 100644 arch/um/kernel/checksum.c
> > 
> > in this case..
> 
> I just realized that this same thing is equally true of just plain mode 
> changes, where wif we don't have any content we just get
> 
> 	diff --git a/name b/name
> 	old mode xxxx
> 	new mode yyyy
> 
> so I might as well parse the diff header here (I don't want to repeat the 
> name twice for mode changes). Oh well.

Given that git already has the metadata lines in the diff ("old mode", "deleted file mode", etc) why not simply add another metadata line "name" and what follows that is the name until an end of line character (or a NUL if you want file names with embedded new lines). You can then only emit the "name" metadata line when no actual diff is present and hence the name is uncertain.

Best regards,

	Anton

-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/