Re: [PATCH] Make sure the diff machinery outputs "\ No newline ..." in english
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Sep 5, 2005, 15:52 UTC
- Message-ID
- <Pine.LNX.4.58.0509050849500.3568@evo.osdl.org>
- In-Reply-To
- <20050905060149.GB1875@c165.ib.student.liu.se>
On Mon, 5 Sep 2005, Fredrik Kuivinen wrote:
Show 5 quoted lines
> > After a quick look through the diff source I didn't find anything > else. It's quite possible that I haved missed something though. Most > of the translated messages are related to error reporting, which I > guess might be nice to have in the user specified language.
Is it possible that we could integrate the "diff" algorithm into git, and get rid of the dependency on an external GNU diff? It would also make the portability problems go away (ie old diff's being broken).
It would also potentially speed up the normal built-in diff a lot, since we wouldn't have to execute a whole other program to generate a diff, just call a helper function the way we do for xdiff..
Unreasonable?
Linus