Re: [PATCH] Make sure the diff machinery outputs "\ No newline ..." in english

From: Junio C Hamano <junkio@cox.net>
Date: Sep 4, 2005, 18:48 UTC
Message-ID: <7vd5nohdp3.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20050904181724.GA23525@c165.ib.student.liu.se>

Fredrik Kuivinen <freku045@student.liu.se> writes:

Show 5 quoted lines

> In non-english locales diff(1) do sometimes output "\ No newline at end of
> file" in some other language. Set LC_ALL to C before execing diff to avoid
> this behaviour.
>
> Signed-off-by: Fredrik Kuivinen <freku045@student.liu.se>

I was thinking about this when I was examining your other patch.

What else, other than the incomplete line marker (and timestamp output it uses by default, which we disable by passing explicit -L flags), are affected by locale in diff output?

Especially, if the diff output is more readable for human consumers (i.e. reviewers) without making it harder to use to machine consumers (i.e. patch or git-apply) when generated under a locale that is 'native' to the data, this patch robs from users the possibility of doing so.

IOW, in a Swedes-only project that tracks a document in Swedish, it _might_ be friendlier and more useful to the users if allowed generating diffs under sv_SE locale, as long as such a diff does not make the processing by patch and git-apply more difficult (which your other patch already solved for git-apply).