Re: Is cogito really this inefficient

From: Linus Torvalds <torvalds@osdl.org>
Date: Jul 15, 2005, 00:29 UTC
Message-ID: <Pine.LNX.4.58.0507141725280.19183@g5.osdl.org>
In-Reply-To: <Pine.LNX.4.58.0507140832490.19183@g5.osdl.org>

On Thu, 14 Jul 2005, Linus Torvalds wrote:

Show 6 quoted lines

>
> I'll look into making diff-cache be more efficient. I normally don't use
> it myself, so I didn't bother (I use git-diff-files, which is way more
> efficient, but doesn't show the difference against the _tree_, it shows
> the difference against the index. Since cogito tries to hide the index
> from you, cogito can't very well use that).

Ok, done.

I made git-diff-cache _and_ git-diff-files limit the pathnames early, so that they don't even bother expanding the tree objects that are irrelevant, and don't bother even validating index objects that don't match the pathnames given.

Junio - I think this makes gitcore-pathspec pretty pointless, but I didn't actually remove it. I guess "git-diff-helper" still uses it.

		Linus