Re: Is cogito really this inefficient

From: Russell King <rmk@arm.linux.org.uk>
Date: Jul 14, 2005, 07:37 UTC
Message-ID: <20050714083700.A26322@flint.arm.linux.org.uk>
In-Reply-To: <Pine.LNX.4.58.0507131325170.17536@g5.osdl.org>

On Wed, Jul 13, 2005 at 01:28:18PM -0700, Linus Torvalds wrote:

Show 12 quoted lines

> On Wed, 13 Jul 2005, Russell King wrote:
> > This says it all.  1min 22secs to generate a patch from a locally
> > modified but uncommitted file.
> 
> No, there's something else going on.
> 
> Most likely that something forced a total index file re-validation, and
> the time you see is every single checked out file having its SHA1
> re-computed.
> 
> Was this a recently cloned tree, or what was the last operation you did on
> that tree before that command? Something must have invalidated the index.

cg-update origin and then I edited drivers/serial/8250.c

As discovered using:

	sh -x /usr/bin/cg-diff drivers/serial/8250.c

it appears that cg-diff does a

	git-update-cache --refresh >/dev/null

each time it's run, which is taking the bulk of the time. Also note that curiously, it exits with status 1.

-- 
Russell King