Re: [PATCH] Cogito: Use git-rev-parse instead of cg-Xnormid.

From: Linus Torvalds <torvalds@osdl.org>
Date: Jul 3, 2005, 22:40 UTC
Message-ID: <Pine.LNX.4.58.0507031535420.3570@g5.osdl.org>
In-Reply-To: <20050703154127.GA31848@pasky.ji.cz>

On Sun, 3 Jul 2005, Petr Baudis wrote:

> 
> That's right. Well, for everything but the short id matching we could
> just check the ID validity by git-rev-parse instead of peeking into
> the object store - I just did that.

What's the format of the short ID? Minimum 6 characters of the SHA1 or something?

Pack-files in many ways should be even easier to look up the ID in, since the pack-file index has all the SHA1's for that pack file listed in sorted order, so it should be fairly easy to just look it up based on the first few bytes.. If somebody sends me a patch, that should be fine.

Show 6 quoted lines

> > The only thing missing is the short id matching.
> 
> Yes, but as I said, I think it's very important to have. BTW, another
> cool thing cg-Xnormid does and git-rev-parse does not: time specifiers.
> E.g. you could specify revisions as "2 days ago" or so, very useful for
> cg-log, cg-diff and such.

That is indeed something that seems to make more sense in cg-Xnormid.

		Linus