Re: [PATCH] Cogito: Use git-rev-parse instead of cg-Xnormid.

From: Petr Baudis <pasky@suse.cz>
Date: Jul 3, 2005, 23:03 UTC
Message-ID: <20050703230351.GE13848@pasky.ji.cz>
In-Reply-To: <Pine.LNX.4.58.0507031535420.3570@g5.osdl.org>

Dear diary, on Mon, Jul 04, 2005 at 12:40:52AM CEST, I got a letter where Linus Torvalds <torvalds@osdl.org> told me that...

Show 15 quoted lines

> 
> 
> On Sun, 3 Jul 2005, Petr Baudis wrote:
> > 
> > That's right. Well, for everything but the short id matching we could
> > just check the ID validity by git-rev-parse instead of peeking into
> > the object store - I just did that.
> 
> What's the format of the short ID? Minimum 6 characters of the SHA1 or
> something?
> 
> Pack-files in many ways should be even easier to look up the ID in, since
> the pack-file index has all the SHA1's for that pack file listed in sorted
> order, so it should be fairly easy to just look it up based on the first
> few bytes.. If somebody sends me a patch, that should be fine.

Actually, the minimum is 4 characters, but that shouldn't be much of an issue. Cogito's behaviour is to raise an error in case of multiple matches; but that could be controlled by a switch too...

	bash$ complete -C git-rev-parse git* cg*

I will cook up a patch in a day or two if noone outruns me.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
<Espy> be careful, some twit might quote you out of context..