Re: [PATCH] Add git-verify-pack command.

From: Linus Torvalds <torvalds@osdl.org>
Date: Jun 29, 2005, 16:15 UTC
Message-ID: <Pine.LNX.4.58.0506290911590.14331@ppc970.osdl.org>
In-Reply-To: <7vvf3xcwyo.fsf_-_@assigned-by-dhcp.cox.net>

On Wed, 29 Jun 2005, Junio C Hamano wrote:

Show 5 quoted lines

> 
> *** Linus, what would be the practical/recommended/sane limit
> *** for mmap regions we would want to use?  Currently I start
> *** throwing away mapped packs when the total size of mapped
> *** packs exceeds 64MB.

Hey, anybody who ever used BK had better have had 1GB of memory for any real development. So 64MB is peanuts, but it sounds like a good guess.

> *** Oh, again, Linus, what is your preferred way to get a
> *** cover-letter material (like this) for a single patch?

I don't want cover-letters for single patches, or necessarily even for short series (1-3 entries). The cover letter is more interesting for large series, or even with small series if the early patches don't make much sense on their own: then the cover-letter ends up being a useful place to explain what the _sequence_ does, and why patch #2 that seems to be totally useless and removes a feature is actually good ("we'll re-implement it better in #5 after we've cleaned the code up").

So generally commentaries after the three dashes is good, if the commentary is "local", ie related not to a series. Only with non-local explanations does a separate [0/N] thing make sense to me.

		Linus