Re: kernel.org and GIT tree rebuilding
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Jun 29, 2005, 05:54 UTC
- Message-ID
- <Pine.LNX.4.58.0506282252001.14331@ppc970.osdl.org>
- In-Reply-To
- <Pine.LNX.4.58.0506282243180.19755@ppc970.osdl.org>
On Tue, 28 Jun 2005, Linus Torvalds wrote:
Show 8 quoted lines
> > On Wed, 29 Jun 2005, Nicolas Pitre wrote: > > > > Of course by the time I sent the above you already rewrote the ting to > > be streamable. > > And by the time you sent me a new version, I'd already taken part of your > old one by hand ;)
Btw, I have the size/type bits reversed from your setup, but please don't change that, since that would be yet another incompatible pack format change, and I'd like to calm things down.
Also, I notice that you decode the sizes really strangely: you have a "while() { }" loop and two separate loads. It's much nicer to do it with a "do { } while()" loop and a single load, since not only is it less code, a do-while loop compiles to better code than a while() loop (unless the compiler is crazy, which it sometimes is).
Linus