Re: git-rev-list: proper lazy reachability

From: Linus Torvalds <torvalds@osdl.org>
Date: May 31, 2005, 14:39 UTC
Message-ID: <Pine.LNX.4.58.0505310735260.1876@ppc970.osdl.org>
In-Reply-To: <17052.21846.816147.370354@cargo.ozlabs.ibm.com>

On Tue, 31 May 2005, Paul Mackerras wrote:

Show 8 quoted lines

> 
> I have made gitk use git-rev-list instead of git-rev-tree, but it
> still absorbs the whole of git-rev-list's output before drawing
> anything.  I'd like to make it draw the commit graph and list
> incrementally as it gets the output from git-rev-list, but to do that
> I need to know whether git-rev-list could ever print a commit ID
> *after* one of its parents.  If it never does that then I can
> restructure the code to do the drawing incrementally fairly easily.

You should never see a parent before a child from git-rev-list. I may have screwed something up when I move things between the two lists (the before/after thing needs to first do the reachability thing on one list, and then moves them to the "potential output list"), but I don't think so.

Anyway, at that point it would be a git-rev-list bug, so if you can make your code notice and complain ("git-rev-list listed parent before child") rather than silently show crud, that would help debugging it if it ever happened.

		Linus