Re: [PATCH] The diff-raw format updates.

From: Linus Torvalds <torvalds@osdl.org>
Date: May 23, 2005, 01:07 UTC
Message-ID: <Pine.LNX.4.58.0505221751070.2307@ppc970.osdl.org>
In-Reply-To: <7vu0kubwyg.fsf@assigned-by-dhcp.cox.net>

On Sun, 22 May 2005, Junio C Hamano wrote:

> 
>  (2) diff_flush() currently prunes _all_ the unmodified entries
>      just before output happens.  This is a _bug_ as you said.
>      To fix this, first, separate that pruning part

I don't understand why this is so hard.

The built-in diff knows to do the right thing. That means that the information is there, in xfrm_msg.

Instead of making a big deal out of this, why not admit that "xfrm_msg" was a mistake, and it should be replaced with just a flag about what that thing is. Make the flag be "diff", "copy" or "rename". Add another field to say how good a match it was, and then let the people who now use xfrm_msg generate the string instead.

The fact is, we alreadt _have_ the information, but it's been corrupted into a string too early, making it hard to get at. No?

		Linus