Re: [PATCH] The diff-raw format updates.
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 22, 2005, 19:20 UTC
- Message-ID
- <7v64xbdq4y.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.58.0505221203410.2307@ppc970.osdl.org>
>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:
LT> The machine readable format has the same issue: it needs to be able to LT> distinguish between a "copy" (where the source remains) and a "rename" LT> (where the source is removed).
Why? If the same path appears later as the left hand side then it is a copy otherwise it is a rename. Please see what diffcore-rename does when assigning to dp->xfrm_msg.
What I've been trying hard so far was to keep diff_filepair not to be too specific to rename/copy. What I do not like about what is being proposed is that it would force me to introduce this "is this a copy or a rename" flag to that structure.