git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Alternate Patch: [PATCH] Don't include device number in cache invalidation when running on NFS

From
Linus Torvalds <torvalds@osdl.org>
Date
May 22, 2005, 21:58 UTC
Message-ID
<Pine.LNX.4.58.0505221451590.2307@ppc970.osdl.org>
In-Reply-To
<20050522214115.GD23388@cip.informatik.uni-erlangen.de>
On Sun, 22 May 2005, Thomas Glanzmann wrote:
> 
> While reading liblockfile I saw the following:

This is _really_ Linux-specific afaik. Which is ok for git, but at the same time it really makes me go "Ewww". It's testing that the major number is 0, and it would be a lot more cleaner to use 

	if (!major(st.st_dev))
but even that is very Linux-specific.
> [PATCH] Don't include device number in cache invalidation when running on NFS

I'll have to think about it. Maybe I should just remove the st_dev check. I guess inode/size/mtime/ctime should be plenty safe enough in practice.

		Linus
Previous: Thomas GlanzmannNext: Thomas Glanzmann
Message 7 of 8 in “running git-update-cache --refresh on different machines on a NFS share always ends up in a lot of io/cpu/time waste”
  1. Thomas GlanzmannMay 22, 2005
  2. Linus TorvaldsMay 22, 2005
  3. Thomas GlanzmannMay 22, 2005
  4. Linus TorvaldsMay 22, 2005
  5. Don't include devicenumber into INODE_CHANGED test [WAS: Re: running git-update-cache --refresh on different machines on a NFS share always ends up in a lot of io/cpu/time waste]Thomas Glanzmann, May 22, 2005
  6. Alternate Patch: [PATCH] Don't include device number in cache invalidation when running on NFSThomas Glanzmann, May 22, 2005
  7. Linus TorvaldsMay 22, 2005
  8. Thomas GlanzmannMay 22, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.