From: Linus Torvalds Date: Sun, 22 May 2005 21:58:39 GMT Subject: Re: Alternate Patch: [PATCH] Don't include device number in cache invalidation when running on NFS Message-ID: In-Reply-To: <20050522214115.GD23388@cip.informatik.uni-erlangen.de> On Sun, 22 May 2005, Thomas Glanzmann wrote: > > While reading liblockfile I saw the following: This is _really_ Linux-specific afaik. Which is ok for git, but at the same time it really makes me go "Ewww". It's testing that the major number is 0, and it would be a lot more cleaner to use if (!major(st.st_dev)) but even that is very Linux-specific. > [PATCH] Don't include device number in cache invalidation when running on NFS I'll have to think about it. Maybe I should just remove the st_dev check. I guess inode/size/mtime/ctime should be plenty safe enough in practice. Linus