git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[patch] fix for memory leak in write-tree.c

From
BRBrad Roberts <braddr@puremagic.com>
Date
Apr 17, 2005, 11:21 UTC
Message-ID
<Pine.LNX.4.44.0504170418390.2625-100000@bellevue.puremagic.com>
I've made my tree rsync'able:
rsync://gameboy2.puremagic.com/git

commit 1cdbc0a19b8d9b68f1f42735e2f14f1289823a63 tree 0e060fed0642337e675368913ec8d4f910a9f019 parent 11ed64c1b141c9ba397a1ca76aef2cd250976007 author Brad Roberts,,, <braddr@gameboy2> 1113736632 -0700 committer Brad Roberts,,, <braddr@gameboy2> 1113736632 -0700

Fix a memory leak in write-tree.c, not freeing the directory buffer.
Index: write-tree.c
===================================================================
--- 51b1bddbbc05e50d5bbf1f9662e503c2e85d5e96/write-tree.c  (mode:100644 sha1:34a351b20fb38ea588f34bd9634f101b9dc533cb)
+++ 0e060fed0642337e675368913ec8d4f910a9f019/write-tree.c  (mode:100644 sha1:fb046aa6ce6b9fce6a523a1e36ff43adab9bdd93)
@@ -93,10 +93,8 @@
        i -= 5;
        memcpy(buffer+i, "tree ", 5);

-       buffer += i;
-       offset -= i;
-
-       write_sha1_file(buffer, offset, returnsha1);
+       write_sha1_file(buffer + i, offset - i, returnsha1);
+       free(buffer);
        return nr;
 }
Next: Petr Baudis
Message 1 of 2 in “fix for memory leak in write-tree.c”
  1. fix for memory leak in write-tree.cBrad Roberts, Apr 17, 2005
  2. Petr BaudisApr 17, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.