threads / patch / 83

patchfix for memory leak in write-tree.c

Subject: [patch] fix for memory leak in write-tree.c

## tl;dr

2 messages between Apr 17, 2005 and Apr 17, 2005. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Brad Roberts· Apr 17, 2005, 11:21 UTC · lore

I've made my tree rsync'able:

rsync://gameboy2.puremagic.com/git

commit 1cdbc0a19b8d9b68f1f42735e2f14f1289823a63 tree 0e060fed0642337e675368913ec8d4f910a9f019 parent 11ed64c1b141c9ba397a1ca76aef2cd250976007 author Brad Roberts,,, <braddr@gameboy2> 1113736632 -0700 committer Brad Roberts,,, <braddr@gameboy2> 1113736632 -0700

Fix a memory leak in write-tree.c, not freeing the directory buffer.

Show changes to diff +2 −4

Index: write-tree.c
===================================================================
--- 51b1bddbbc05e50d5bbf1f9662e503c2e85d5e96/write-tree.c  (mode:100644 sha1:34a351b20fb38ea588f34bd9634f101b9dc533cb)
+++ 0e060fed0642337e675368913ec8d4f910a9f019/write-tree.c  (mode:100644 sha1:fb046aa6ce6b9fce6a523a1e36ff43adab9bdd93)
@@ -93,10 +93,8 @@
        i -= 5;
        memcpy(buffer+i, "tree ", 5);

-       buffer += i;
-       offset -= i;
-
-       write_sha1_file(buffer, offset, returnsha1);
+       write_sha1_file(buffer + i, offset - i, returnsha1);
+       free(buffer);
        return nr;
 }

Petr Baudis· Apr 17, 2005, 11:23 UTC · re: Brad Roberts · lore

Re: fix for memory leak in write-tree.c

Dear diary, on Sun, Apr 17, 2005 at 01:21:56PM CEST, I got a letter where Brad Roberts <braddr@puremagic.com> told me that...

Show 10 quoted lines

> I've made my tree rsync'able:
> 
> rsync://gameboy2.puremagic.com/git
> 
> 
> commit 1cdbc0a19b8d9b68f1f42735e2f14f1289823a63
> tree 0e060fed0642337e675368913ec8d4f910a9f019
> parent 11ed64c1b141c9ba397a1ca76aef2cd250976007
> author Brad Roberts,,, <braddr@gameboy2> 1113736632 -0700
> committer Brad Roberts,,, <braddr@gameboy2> 1113736632 -0700

If we are supposed to merge with you, it would be nice if you used a real email address. (The commas are livable but if you can get rid of them... ;-)

Thanks,

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor