git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 3/8] status: Added missing calls to diff_unmodified_pair() in format_callbacks.

From
HGHenrik Grubbström <grubba@roxen.com>
Date
Apr 12, 2010, 13:00 UTC
Message-ID
<Pine.GSO.4.63.1004121453310.1164@shipon.roxen.com>
In-Reply-To
<7vaatbueg5.fsf@alter.siamese.dyndns.org>
On Sat, 10 Apr 2010, Junio C Hamano wrote:
Show 13 quoted lines
> "Henrik Grubbström (Grubba)"  <grubba@grubba.org> writes:
>
>> The diff_queue_struct provided by diff_flush() is raw, and needs to be
>> filtered through diff_unmodified_pair() before being used.
>> This is already done by most of the other functions operating on
>> diff_queue_struct called by diff_flush().
>
> That is true but only if you are letting the diff front-end to feed
> unmodified pairs to begin with, e.g. --find-copies-harder.  I don't think
> the internal caller in wt-status does that.
>
> I don't think the patch is wrong nor it would hurt, but I am puzzled why
> you needed this patch.

Well, it's a prerequisite for the diff: Filter files that have changed... patch, albeit apparently not sufficient (yet).

-- Henrik Grubbström grubba@grubba.org Roxen Internet Software AB grubba@roxen.com

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 14 in “Attribute and conversion patches”
  1. 0/8 Attribute and conversion patchesHenrik Grubbström (Grubba), Apr 6, 2010
  2. 1/8 convert: Safer handling of $Id$ contraction.Henrik Grubbström (Grubba), Apr 6, 2010
  3. 2/8 convert: Keep foreign $Id$ on checkout.Henrik Grubbström (Grubba), Apr 6, 2010
  4. 3/8 status: Added missing calls to diff_unmodified_pair() in format_callbacks.Henrik Grubbström (Grubba), Apr 6, 2010
  5. Junio C HamanoApr 10, 2010
  6. Henrik GrubbströmApr 12, 2010
  7. Junio C HamanoApr 10, 2010
  8. 4/8 diff: Filter files that have changed only due to conversion changes.Henrik Grubbström (Grubba), Apr 6, 2010
  9. Junio C HamanoApr 10, 2010
  10. Henrik GrubbströmApr 16, 2010
  11. 5/8 convert: Added core.refilteronadd feature.Henrik Grubbström (Grubba), Apr 6, 2010
  12. 6/8 attr: Fixed debug output for macro expansion.Henrik Grubbström (Grubba), Apr 6, 2010
  13. 7/8 attr: Allow multiple changes to an attribute on the same line.Henrik Grubbström (Grubba), Apr 6, 2010
  14. 8/8 attr: Expand macros immediately when encountered.Henrik Grubbström (Grubba), Apr 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.