Re: [PATCH v4 3/8] status: Added missing calls to diff_unmodified_pair() in format_callbacks.

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2010, 22:31 UTC
Message-ID: <7vaatbueg5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <5962221bef558d15183c9937863b38bc7ca41339.1270554878.git.grubba@grubba.org>

"Henrik Grubbström (Grubba)"  <grubba@grubba.org> writes:

> The diff_queue_struct provided by diff_flush() is raw, and needs to be
> filtered through diff_unmodified_pair() before being used.
> This is already done by most of the other functions operating on
> diff_queue_struct called by diff_flush().

That is true but only if you are letting the diff front-end to feed unmodified pairs to begin with, e.g. --find-copies-harder. I don't think the internal caller in wt-status does that.

I don't think the patch is wrong nor it would hurt, but I am puzzled why you needed this patch.

>  wt-status.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)