Re: git imap-send converting my patches to CRLF line endings?

From: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>
Date: Jun 17, 2011, 15:37 UTC
Message-ID: <Oe8m5NtYZicsi6Z4FtNIXAfsB9Q9XcHSsoAYmKdxQkoDVJOKykQTEg@cipher.nrlssc.navy.mil>
In-Reply-To: <Svak9atXpisIKwqaYKGMzry3LEHEDPnWLLqFpfgP7IOuAVUdRy8brA@cipher.nrlssc.navy.mil>

On 06/17/2011 10:08 AM, Brandon Casey wrote:

Show 13 quoted lines

> On 06/17/2011 09:45 AM, Michael Mc Donnell wrote:
>> On Fri, Jun 17, 2011 at 4:14 PM, Jeff King <peff@peff.net> wrote:
>>> On Fri, Jun 17, 2011 at 03:35:04PM +0200, Michael Mc Donnell wrote:
> 
>>> How do you download and apply the patch exactly? If you are speaking
>>> imap to gmail, generally the client would strip out the CR's from the
>>> mail.
>>
>> I'm just downloading it with Chrome.
>>
>> Steps to reproduce:
>> 1. Upload patch via:
>> $ git format-patch --stdout --keep-subject --attach origin | git imap-send

Wait a second.  You used --attach.

>> 2. Open Gmail in Chrome.
>> 3. Open email in drafts folder.
>> 4. Click attachment download link

Then you downloaded the attachment, which should be a _patch_.

>> 5. Apply patch on a fresh branch with git apply.

Well, scratch what I said before, you were correct in using git apply.

Shouldn't the attachment have it's content preserved exactly? Maybe the fault does belong to gmail.

-Brandon