Re: git imap-send converting my patches to CRLF line endings?

From: Jeff King <peff@peff.net>
Date: Jun 17, 2011, 14:14 UTC
Message-ID: <20110617141450.GA12114@sigill.intra.peff.net>
In-Reply-To: <BANLkTimXQQX_Fu0fgtWneF2cCLUZFhTaCg@mail.gmail.com>

On Fri, Jun 17, 2011 at 03:35:04PM +0200, Michael Mc Donnell wrote:

> I'm using git imap-send to send patches to wine-patches, and it seems
> like it converts all my patches to have CRLF line endings?

The canonical line ending for mail is CRLF. So yes, it will convert your patch to CRLF for storage. But anything pulling it out of the IMAP folder should convert it back to native line endings.

> I can see it when I download the patch from the Gmail drafts folder.
> Git complains about white space when I apply the downloaded patch. It
> works fine if I just use git to create the patch and then apply it on
> a new branch. Is it git imap-send or just Gmail that's the problem?

How do you download and apply the patch exactly? If you are speaking imap to gmail, generally the client would strip out the CR's from the mail.

-Peff