git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t7502-commit.sh: rearrange test to make more portable

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Jul 22, 2008, 21:21 UTC
Message-ID
<Koa4iojOlOQ_YENPwWXKt7G8Aa1x6UaBnFFtliKdZmpcrrqOBhY7NQ@cipher.nrlssc.navy.mil>
In-Reply-To
<0GfECozN3g0ZvAESKMi76RyOVHEb2OhhwET9GWmEm7pbzYQJub50UlWpZtBa7MGn1UGb-7mzbzE@cipher.nrlssc.navy.mil>

Some shells have problems with one-shot variable assignment notation and function calls. The sequence is rearranged to avoid the one-shot and to allow the test script to be linked together with '&&'.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 t/t7502-commit.sh |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
index c25eff9..ad84c3d 100755
--- a/t/t7502-commit.sh
+++ b/t/t7502-commit.sh
@@ -228,10 +228,12 @@ EOF
 
 test_expect_success 'a SIGTERM should break locks' '
 	echo >>negative &&
-	"$SHELL_PATH" -c '\''
+	! "$SHELL_PATH" -c '\''
 	  echo kill -TERM $$ >> .git/FAKE_EDITOR
-	  GIT_EDITOR=.git/FAKE_EDITOR exec git commit -a'\'' && exit 1  # should fail
-	! test -f .git/index.lock
+	  GIT_EDITOR=.git/FAKE_EDITOR 
+	  export GIT_EDITOR
+	  exec git commit -a'\'' &&
+	test ! -f .git/index.lock
 '
 
 rm -f .git/MERGE_MSG .git/COMMIT_EDITMSG
-- 
1.6.0.rc0.38.g8b8fb7
Previous: Brandon CaseyNext: Brandon Casey
Message 22 of 23 in “perl/Makefile: update NO_PERL_MAKEMAKER section”
  1. perl/Makefile: update NO_PERL_MAKEMAKER sectionBrandon Casey, Jul 22, 2008
  2. Petr BaudisJul 22, 2008
  3. Brandon CaseyJul 23, 2008
  4. Junio C HamanoJul 23, 2008
  5. Brandon CaseyJul 23, 2008
  6. t9700/test.pl: backwards compatibility improvementsBrandon Casey, Jul 22, 2008
  7. Junio C HamanoJul 23, 2008
  8. Brandon CaseyJul 24, 2008
  9. t4116-apply-reverse.sh: use $TAR rather than tarBrandon Casey, Jul 22, 2008
  10. Set TAR in t/Makefile and in t4116-apply-reverse.shStephan Beyer, Jul 25, 2008
  11. Miklos VajnaJul 25, 2008
  12. Stephan BeyerJul 25, 2008
  13. Junio C HamanoJul 25, 2008
  14. Stephan BeyerJul 25, 2008
  15. Junio C HamanoJul 25, 2008
  16. Stephan BeyerJul 25, 2008
  17. Junio C HamanoJul 25, 2008
  18. t3200,t7201: replace '!' with test_must_failBrandon Casey, Jul 22, 2008
  19. t/: Replace diff [-u|-U0] with test_cmp to allow compilation with old diffBrandon Casey, Jul 22, 2008
  20. Miklos VajnaJul 24, 2008
  21. Brandon CaseyJul 24, 2008
  22. t7502-commit.sh: rearrange test to make more portableBrandon Casey, Jul 22, 2008
  23. t/t4202-log.sh: add newline at end of fileBrandon Casey, Jul 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.