Re: [PATCH] Set TAR in t/Makefile and in t4116-apply-reverse.sh
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 25, 2008, 18:18 UTC
- Message-ID
- <7vvdytsu7n.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1217003860-10609-1-git-send-email-s-beyer@gmx.net>
Actually, 455a7f3 (More portability., 2005-09-30) introduced $TAR and it is also used in t5000. cb34882 (fix t5000-tar-tree.sh when $TAR isn't set, 2005-11-08) did the same fix you are adding, but I think both of these fixes are in a wrong place.
I think we should do this instead. That's how SHELL_PATH is passed around from build to all the test scripts already.
--- Makefile | 1 + t/t5000-tar-tree.sh | 1 - 2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile index b003e3e..1d14209 100644 --- a/Makefile +++ b/Makefile @@ -1212,6 +1212,7 @@ GIT-CFLAGS: .FORCE-GIT-CFLAGS GIT-BUILD-OPTIONS: .FORCE-GIT-BUILD-OPTIONS @echo SHELL_PATH=\''$(SHELL_PATH_SQ)'\' >$@ + @echo TAR=\''$(subst ','\'',$(TAR))'\' >>$@ ### Detect Tck/Tk interpreter path changes ifndef NO_TCLTK diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh index 9b0baac..5eb119e 100755 --- a/t/t5000-tar-tree.sh +++ b/t/t5000-tar-tree.sh @@ -25,7 +25,6 @@ commit id embedding: ' . ./test-lib.sh -TAR=${TAR:-tar} UNZIP=${UNZIP:-unzip} SUBSTFORMAT=%H%n