git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/4] diff.c: return pattern entry pointer rather than just the hunk header pattern

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Sep 19, 2008, 19:11 UTC
Message-ID
<IWyC0OwsyyNa-yfA29138St-i1ziYm_Ijietm8MzVB8@cipher.nrlssc.navy.mil>
In-Reply-To
<alpine.LNX.1.10.0809191209450.10710@suse104.zenez.com>
Boyd Lynn Gerber wrote:
> So on these patches,
> What do you want me to do?  I applied them and things kinda worked.

Test t4018-diff-funcname.sh should pass. As Johan mentioned, in the last patch '\\s' should have been converted to '[ \t]', rather than to just ' ', but that should not affect the test and should only affect html, python, and ruby patterns.

It would be nice if the tests were expanded.
>  The
> problem is pine/alpine messes them up a bit and it is not easy to
> manually fix them.  It would be easier to git clone/pull them from
> either a site or the trees.

I expect they will be in Junio's tree soon, most likely the master branch.

>I do think that on some we should use the
> actual charact vers the C-syntax.  "\t" for example.

"\t" is safe to use since it is interpreted by git in config.c: parse_value(), not by the regex library. I was also concerned about that character until I traced the code to parse_value(). Junio is right that better documentation of this feature is needed.

-brandon
Previous: Boyd Lynn GerberNext: Brandon Casey
Message 3 of 26 in “diff.c: return pattern entry pointer rather than just the hunk header pattern”
  1. 1/4 diff.c: return pattern entry pointer rather than just the hunk header patternBrandon Casey, Sep 18, 2008
  2. Boyd Lynn GerberSep 19, 2008
  3. Brandon CaseySep 19, 2008
  4. 2/4 diff.c: associate a flag with each pattern and use it for compiling regexBrandon Casey, Sep 18, 2008
  5. 3/4 diff.*.xfuncname which uses "extended" regex's for hunk header selectionBrandon Casey, Sep 18, 2008
  6. 4/4 diff.c: convert builtin funcname patterns to non-GNU extended regex syntaxBrandon Casey, Sep 18, 2008
  7. Brandon CaseySep 18, 2008
  8. Brandon CaseySep 19, 2008
  9. Johan HerlandSep 18, 2008
  10. Brandon CaseySep 19, 2008
  11. Junio C HamanoSep 19, 2008
  12. Junio C HamanoSep 20, 2008
  13. Brandon CaseySep 20, 2008
  14. Junio C HamanoSep 20, 2008
  15. Brandon CaseySep 22, 2008
  16. Brandon CaseySep 24, 2008
  17. Brandon CaseySep 26, 2008
  18. diff.c: remove duplicate bibtex pattern introduced by merge 92bb9785Brandon Casey, Sep 29, 2008
  19. t4018-diff-funcname: test syntax of builtin xfuncname patternsBrandon Casey, Sep 22, 2008
  20. t4018-diff-funcname: test syntax of builtin xfuncname patternsBrandon Casey, Sep 22, 2008
  21. diff funcname_pattern: Allow HTML header tags without attributesJohan Herland, Sep 23, 2008
  22. Junio C HamanoSep 23, 2008
  23. Johan HerlandSep 23, 2008
  24. Junio C HamanoSep 20, 2008
  25. Junio C HamanoSep 20, 2008
  26. Gustaf HendebySep 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.