Re: [PATCH v2 4/4] diff.c: convert builtin funcname patterns to non-GNU extended regex syntax

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 19, 2008, 20:29 UTC
Message-ID: <7v7i97swv3.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <4i0Mu795rKpv37JoHytmE6kODBjwgwITn0-DuKdZiFs3ZnUlyJC-Fw@cipher.nrlssc.navy.mil>

Brandon Casey <casey@nrlssc.navy.mil> writes:

> The 'non-GNU' part of this basic RE to extended RE conversion means '\\s' was
> converted to ' '.

I think a large part of this series should be in 'maint', as the existing hunk head pattern engine does _not_ work for people without GNU regexp.

I've created two branches to house this topic:

 - bc/maint-diff-hunk-header-fix is rebased to 'maint', so that after
   testing we can merge it to 'maint' for 1.6.0.3 and later versions.

   Its current tip is at 45d9414;

 - bc/master-diff-hunk-header-fix forks from the above, and merges later
   "language" additions that happened on 'master'.  We can merge this
   after testing to 'master' for 1.6.1.

   Its current tip is at dde4af4.

Neither has [4/4] on it.  I'd like two patches so that:

 * [PATCH 1/2] applies to bc/maint-diff-hunk-header-fix, so that the
   languages in 1.6.0.2 are fixed for non GNU platforms;

 * After applying [1/2] to bc/maint-diff-hunk-header-fix, I'll merge the
   branch to bc/master-diff-hunk-header-fix and then...

 * [PATCH 2/2] applies on top of it to convert new languages that are
   supported only on 'master' to use xfuncname.