git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] submodule recursion in git-archive

From
Nick Townsend <nick.townsend@mac.com>
Date
Nov 27, 2013, 03:28 UTC
Message-ID
<FE55CF9D-FE21-4DCA-A819-0B3E6D378C57@mac.com>
In-Reply-To
<52953CB7.8020300@web.de>
On 26 Nov 2013, at 16:28, René Scharfe <l.s.r@web.de> wrote:
Show 70 quoted lines
> Am 26.11.2013 23:18, schrieb Junio C Hamano:
>> René Scharfe <l.s.r@web.de> writes:
>> 
>>> Thanks for the patches!  Please send only one per message (the second
>>> one as a reply to the first one, or both as replies to a cover letter),
>>> though -- that makes commenting on them much easier.
>>> 
>>> Side note: Documentation/SubmittingPatches doesn't mention that (yet),
>>> AFAICS.
>> 
>> OK, how about doing this then?
>> 
>> Documentation/SubmittingPatches | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
>> index 7055576..304b3c0 100644
>> --- a/Documentation/SubmittingPatches
>> +++ b/Documentation/SubmittingPatches
>> @@ -140,7 +140,12 @@ comment on the changes you are submitting.  It is important for
>> a developer to be able to "quote" your changes, using standard
>> e-mail tools, so that they may comment on specific portions of
>> your code.  For this reason, all patches should be submitted
>> -"inline".  If your log message (including your name on the
>> +"inline".  A patch series that consists of N commits is sent as N
>> +separate e-mail messages, or a cover letter message (see below) with
>> +N separate e-mail messages, each being a response to the cover
>> +letter.
>> +
>> +If your log message (including your name on the
>> Signed-off-by line) is not writable in ASCII, make sure that
>> you send off a message in the correct encoding.
> 
> OK, but the repetition of "cover letter" and "e-mail messages"
> irritates me slightly for some reason.  What about the following?
> 
> -- >8 --
> Subject: [PATCH] SubmittingPatches: document how to handle multiple patches
> 
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> Documentation/SubmittingPatches |   11 +++++++++--
> 1 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 7055576..e6d46ed 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -139,8 +139,15 @@ People on the Git mailing list need to be able to read and
> comment on the changes you are submitting.  It is important for
> a developer to be able to "quote" your changes, using standard
> e-mail tools, so that they may comment on specific portions of
> -your code.  For this reason, all patches should be submitted
> -"inline".  If your log message (including your name on the
> +your code.  For this reason, each patch should be submitted
> +"inline" in a separate message.
> +
> +Multiple related patches should be grouped into their own e-mail
> +thread to help readers find all parts of the series.  To that end,
> +send them as replies to either an additional "cover letter" message
> +(see below), the first patch, or the respective preceding patch.
> +
> +If your log message (including your name on the
> Signed-off-by line) is not writable in ASCII, make sure that
> you send off a message in the correct encoding.
> 
> -- 
> 1.7.8
> 
> 

That seems clear to me. At any rate I’m going to rework this based on the collective input and will submit them again. Please check my other replies as there are some discussion points!

Nick
Previous: René ScharfeNext: Junio C Hamano
Message 6 of 14 in “submodule recursion in git-archive”
  1. submodule recursion in git-archiveNick Townsend, Nov 26, 2013
  2. René ScharfeNov 26, 2013
  3. Jens LehmannNov 26, 2013
  4. Junio C HamanoNov 26, 2013
  5. René ScharfeNov 27, 2013
  6. Nick TownsendNov 27, 2013
  7. Junio C HamanoNov 27, 2013
  8. Nick TownsendNov 27, 2013
  9. Junio C HamanoNov 27, 2013
  10. Heiko VoigtNov 29, 2013
  11. Nick TownsendDec 3, 2013
  12. Fwd: [PATCH] submodule recursion in git-archiveNick Townsend, Dec 3, 2013
  13. Heiko VoigtNov 26, 2013
  14. Nick TownsendNov 27, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.