Re: [PATCH] submodule recursion in git-archive

From: Jens Lehmann <jens.lehmann@web.de>
Date: Nov 26, 2013, 18:57 UTC
Message-ID: <5294EF14.7000204@web.de>
In-Reply-To: <5294BB97.7010707@web.de>

Am 26.11.2013 16:17, schrieb René Scharfe:

Show 16 quoted lines

> Am 26.11.2013 01:04, schrieb Nick Townsend:
>> diff --git a/Documentation/git-archive.txt b/Documentation/git-archive.txt
>> index b97aaab..b4df735 100644
>> --- a/Documentation/git-archive.txt
>> +++ b/Documentation/git-archive.txt
>> @@ -11,6 +11,7 @@ SYNOPSIS
>>  [verse]
>>  'git archive' [--format=<fmt>] [--list] [--prefix=<prefix>/] [<extra>]
>>  	      [-o <file> | --output=<file>] [--worktree-attributes]
>> +	      [--recursive|--recurse-submodules]
> 
> I'd expect git archive --recurse to add subdirectories and their
> contents, which it does right now, and --no-recurse to only archive the
> specified objects, which is not implemented.  IAW: I wouldn't normally
> associate an option with that name with submodules.  Would
> --recurse-submodules alone suffice?

It should. All new code recursing into submodules should not use --recursive but always --recurse-submodules, as --recursive means different things for different commands (the only exception being "git submodule", as --recursive is obvious here, and "git clone" for backward compatibility reasons).

But I really like what these patches are aiming at.